Issue 5380 - Separate cleanAllRUV code into new file #5381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Firstyear
reviewed
Jul 25, 2022
No changes to the server code, except I fixed a CI test to make it more robust |
jchapma
approved these changes
Jul 25, 2022
Description: A majority of the cleanAllruv code is jammed inside of rep5_replica_config.c. It really deserves it's own file which will make it easier to analyze and troubleshoot (especially for people not familiar with it). Also, revised the CI "force" tests to make them more robust. relates: 389ds#5380 Reviewed by: jchapman & firstyear (Thanks!!)
mreynolds389
force-pushed
the
move-cleanallruv-code
branch
from
cadfa8f
to
7e879ca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
A majority of the cleanAllruv code is jammed inside of
rep5_replica_config.c. It really deserves it's own file which will make
it easier to analyze and troubleshoot (especially for people not
familiar with it).
Also, revised the CI "force" tests to make them more robust.
relates: #5380